Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant which_slice from plasma particle advance #328

Merged
merged 2 commits into from
Jan 26, 2021

Conversation

SeverinDiederichs
Copy link
Member

@SeverinDiederichs SeverinDiederichs commented Jan 21, 2021

This PR resolves #318.
We originally passed which_slice to the plasma particle pusher. However, this is not used anymore and is removed in this PR.

  • Small enough (< few 100s of lines), otherwise it should probably be split into smaller PRs
  • Tested (describe the tests in the PR description)
  • Runs on GPU (basic: the code compiles and run well with the new module)
  • Contains an automated test (checksum and/or comparison with theory)
  • Documented: all elements (classes and their members, functions, namespaces, etc.) are documented
  • Constified (All that can be const is const)
  • Code is clean (no unwanted comments, )
  • Style and code conventions are respected at the bottom of https://github.com/Hi-PACE/hipace
  • Proper label and GitHub project, if applicable

@SeverinDiederichs SeverinDiederichs added component: plasma About the plasma species cleaning Code cleaning, avoid duplication, better naming, better style etc. labels Jan 21, 2021
Copy link
Member

@MaxThevenet MaxThevenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely, thanks!! 💖

@MaxThevenet MaxThevenet merged commit 2c69e36 into development Jan 26, 2021
@MaxThevenet MaxThevenet deleted the clean_plasma_particle_advance branch January 26, 2021 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleaning Code cleaning, avoid duplication, better naming, better style etc. component: plasma About the plasma species
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug or typo in plasma particle advance
2 participants