Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mini] renaming to the correctly describing name peak_current_density #350

Merged
merged 1 commit into from
Feb 16, 2021

Conversation

SeverinDiederichs
Copy link
Member

As @MaxThevenet pointed out, the name amplitude for the grid current is a bit misleading.
This PR names it correctly to peak_current_density, which it is.

  • Small enough (< few 100s of lines), otherwise it should probably be split into smaller PRs
  • Tested (describe the tests in the PR description)
  • Runs on GPU (basic: the code compiles and run well with the new module)
  • Contains an automated test (checksum and/or comparison with theory)
  • Documented: all elements (classes and their members, functions, namespaces, etc.) are documented
  • Constified (All that can be const is const)
  • Code is clean (no unwanted comments, )
  • Style and code conventions are respected at the bottom of https://github.com/Hi-PACE/hipace
  • Proper label and GitHub project, if applicable

@SeverinDiederichs SeverinDiederichs added the cleaning Code cleaning, avoid duplication, better naming, better style etc. label Feb 16, 2021
@MaxThevenet MaxThevenet merged commit afc4cae into development Feb 16, 2021
@MaxThevenet MaxThevenet deleted the renaming_amplitude_in_gridcurrent branch February 16, 2021 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleaning Code cleaning, avoid duplication, better naming, better style etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants