Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add the possibility to have a parabolic plasma profile #415

Merged
merged 3 commits into from
Mar 25, 2021

Conversation

SeverinDiederichs
Copy link
Member

@SeverinDiederichs SeverinDiederichs commented Mar 9, 2021

This PR adds a parabolic profile to the plasma.
The curvature is defined via plasma.parabolic_curvature.
The plasma profile is set to parabolic_curvature*r^2 + density,

Note, that very high density plasma particles at the boundary can cause problems and can cause the simulation to diverge.
Therefore, the curvature must be chosen with care.

  • Small enough (< few 100s of lines), otherwise it should probably be split into smaller PRs
  • Tested (describe the tests in the PR description)
  • Runs on GPU (basic: the code compiles and run well with the new module)
  • Contains an automated test (checksum and/or comparison with theory)
  • Documented: all elements (classes and their members, functions, namespaces, etc.) are documented
  • Constified (All that can be const is const)
  • Code is clean (no unwanted comments, )
  • Style and code conventions are respected at the bottom of https://github.com/Hi-PACE/hipace
  • Proper label and GitHub project, if applicable

@SeverinDiederichs SeverinDiederichs added the component: plasma About the plasma species label Mar 9, 2021
Copy link
Member

@MaxThevenet MaxThevenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR! See comments.

doc/source/run/parameters.rst Outdated Show resolved Hide resolved
src/particles/PlasmaParticleContainer.cpp Outdated Show resolved Hide resolved
src/particles/PlasmaParticleContainerInit.cpp Outdated Show resolved Hide resolved
src/particles/PlasmaParticleContainerInit.cpp Outdated Show resolved Hide resolved
@MaxThevenet
Copy link
Member

Should we consider finalising this PR?

@MaxThevenet
Copy link
Member

@SeverinDiederichs
Copy link
Member Author

Copy link
Member

@MaxThevenet MaxThevenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks! See minor suggestion

@SeverinDiederichs SeverinDiederichs merged commit b8338c9 into development Mar 25, 2021
@SeverinDiederichs SeverinDiederichs deleted the parabolic_profile_new branch March 25, 2021 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: plasma About the plasma species
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants