Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove configure_mpiexec from cmake #421

Merged
merged 1 commit into from
Mar 16, 2021
Merged

Remove configure_mpiexec from cmake #421

merged 1 commit into from
Mar 16, 2021

Conversation

MaxThevenet
Copy link
Member

The mpiexec command is currently in a separate bash script for each test, so that we have easy control to the simulation AND post-processing commands (checksum, compare with theory, etc.). Consequently, the configure_mpiexec CMake function isn't needed anymore. This PR proposes to delete its definition. It also includes minor cleaning of the CMakeLists.txt

  • Small enough (< few 100s of lines), otherwise it should probably be split into smaller PRs
  • Tested (describe the tests in the PR description)
  • Runs on GPU (basic: the code compiles and run well with the new module)
  • Contains an automated test (checksum and/or comparison with theory)
  • Documented: all elements (classes and their members, functions, namespaces, etc.) are documented
  • Constified (All that can be const is const)
  • Code is clean (no unwanted comments, )
  • Style and code conventions are respected at the bottom of https://github.com/Hi-PACE/hipace
  • Proper label and GitHub project, if applicable

@MaxThevenet MaxThevenet added cleaning Code cleaning, avoid duplication, better naming, better style etc. build CMake, compilation, etc. labels Mar 10, 2021
@MaxThevenet MaxThevenet requested a review from ax3l March 10, 2021 13:50
Copy link
Member

@SeverinDiederichs SeverinDiederichs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@MaxThevenet MaxThevenet merged commit 56e3ae2 into development Mar 16, 2021
@MaxThevenet MaxThevenet deleted the cmake_clean branch March 16, 2021 11:28
This was referenced Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build CMake, compilation, etc. cleaning Code cleaning, avoid duplication, better naming, better style etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants