Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to not deposit Jx and Jy of the beam #431

Merged
merged 1 commit into from
Mar 17, 2021

Conversation

SeverinDiederichs
Copy link
Member

@SeverinDiederichs SeverinDiederichs commented Mar 17, 2021

This PR adds the possibility to neglect Jx and Jy of the beam, via the parameter
hipace.do_beam_jx_jy_deposition = 0 (default is 1).

image

  • Small enough (< few 100s of lines), otherwise it should probably be split into smaller PRs
  • Tested (describe the tests in the PR description)
  • Runs on GPU (basic: the code compiles and run well with the new module)
  • Contains an automated test (checksum and/or comparison with theory)
  • Documented: all elements (classes and their members, functions, namespaces, etc.) are documented
  • Constified (All that can be const is const)
  • Code is clean (no unwanted comments, )
  • Style and code conventions are respected at the bottom of https://github.com/Hi-PACE/hipace
  • Proper label and GitHub project, if applicable

@SeverinDiederichs SeverinDiederichs added the component: beam About the beam species label Mar 17, 2021
@MaxThevenet MaxThevenet merged commit d2cd531 into development Mar 17, 2021
@MaxThevenet MaxThevenet deleted the beam_deposit_jx_jy branch March 17, 2021 18:26
@MaxThevenet
Copy link
Member

@jlvay @RemiLehe @ax3l:
@SeverinDiederichs identified the source of this noise: it appears when we deposit the transverse currents of the beam, and when there are not that many beam particles. Hipace doesn't deposit the transverse current, so this PR implement the option to do the same.

@ax3l
Copy link
Member

ax3l commented Mar 17, 2021

Awesome, glad you found the source of this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: beam About the beam species
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants