Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print Version #433

Merged
merged 1 commit into from
Mar 22, 2021
Merged

Print Version #433

merged 1 commit into from
Mar 22, 2021

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented Mar 20, 2021

Print the HiPACE++ version to the terminal. Fetched from git as usual. Will use a proper tag-prefixed description as soon as we add tags in the git history.

Same as ECP-WarpX/WarpX#1820

  • Small enough (< few 100s of lines), otherwise it should probably be split into smaller PRs
  • Tested (describe the tests in the PR description)
  • Runs on GPU (basic: the code compiles and run well with the new module)
  • Contains an automated test (checksum and/or comparison with theory)
  • Documented: all elements (classes and their members, functions, namespaces, etc.) are documented
  • Constified (All that can be const is const)
  • Code is clean (no unwanted comments, )
  • Style and code conventions are respected at the bottom of https://github.com/Hi-PACE/hipace
  • Proper label and GitHub project, if applicable

Print the HiPACE++ version to the terminal.
Fetched from `git` as usual. Will use a proper tag-prefixed
description as soon as we add tags in the git history.
@ax3l ax3l added documentation Improvements or additions to documentation build CMake, compilation, etc. labels Mar 20, 2021
@ax3l ax3l requested a review from MaxThevenet March 20, 2021 01:09
Copy link
Member

@MaxThevenet MaxThevenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look great, thanks! Just checked, AMReX also prints the version, so we're good to go.

@MaxThevenet MaxThevenet merged commit 564a767 into development Mar 22, 2021
@MaxThevenet MaxThevenet deleted the topic-versionPrint branch March 22, 2021 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build CMake, compilation, etc. documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants