Add correlated energy spread #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxThevenet
reviewed
Mar 29, 2021
Comment on lines
36
to
54
| /** \brief Get the momentum for a beam particle | ||
| * \param[in,out] ux momentum in x, modified by this function | ||
| * \param[in,out] uy momentum in y, modified by this function | ||
| * \param[in,out] uz momentum in z, modified by this function | ||
| * \param[in] z position in z | ||
| * \param[in] duz_per_uz0_dzeta correlated energy spread | ||
| */ | ||
| void operator() (amrex::Real& ux, amrex::Real& uy, amrex::Real& uz, const amrex::Real z, | ||
| const amrex::Real duz_per_uz0_dzeta) const | ||
| { | ||
| amrex::Real u[3] = {ux,uy,uz}; | ||
| if (m_momentum_profile == BeamMomentumType::Gaussian){ | ||
| ParticleUtil::get_gaussian_random_momentum(u, m_u_mean, m_u_std); | ||
| } | ||
| ux = u[0]; | ||
| uy = u[1]; | ||
| uz = u[2] + z*duz_per_uz0_dzeta*m_u_mean[2]; | ||
| } | ||
|
|
There was a problem hiding this comment.
Could we try using default values instead of duplicating (copy-paste) the whole function? For instance, could we just replace the function prototype
void operator() (amrex::Real& ux, amrex::Real& uy, amrex::Real& uz) const
by
void operator() (amrex::Real& ux, amrex::Real& uy, amrex::Real& uz, const amrex::Real z=0.,
const amrex::Real duz_per_uz0_dzeta=0.) const
?
There was a problem hiding this comment.
Sure. Thanks for the suggestion!
MaxThevenet
approved these changes
Mar 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the possibility to add a chirp to the beam.
The relative correlated energy spread
beam_name.duz_per_uz0_dzetaaddsduz_per_uz0_dzeta * z * uz_meantouzof the beam.zis hereby the relative longitudinal position w.r.t. the mean longitudinal position of the beam.constisconst)