Use previous slice as MG initial guess for explicit solver #450
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes to use Bx and By from the previous slice as an initial guess for the MG solver. We thought is was already the case, but apparently not. Here's a scan to see the improvement. As always, PC means predictor-corrector (old version),
ii
is now development and00
indicates this PR. The improvement is marginal for this example.Looking into
output_0512WPmt04**.txt
I get the following number of MG iterationsSo the new version is converging a bit more often with 2 iterations instead of 3, but it doesn't have a large impact on the runtime. Still, I think it is worth merging this, it could have a bigger impact in some cases (in particular when a lower tolerance is required).