Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix sign of psi #455

Merged
merged 1 commit into from
Apr 17, 2021
Merged

fix sign of psi #455

merged 1 commit into from
Apr 17, 2021

Conversation

SeverinDiederichs
Copy link
Member

@SeverinDiederichs SeverinDiederichs commented Apr 14, 2021

Currently, the psi in the fields is actually -psi. It is only used to calculate ExmBy and EypBx and the missing minus is countered in the calculation.

This PR sets this right, so we actually calculate psi and not -psi.

No benchmarks needed to be updated, as they take the absolute.

  • Small enough (< few 100s of lines), otherwise it should probably be split into smaller PRs
  • Tested (describe the tests in the PR description)
  • Runs on GPU (basic: the code compiles and run well with the new module)
  • Contains an automated test (checksum and/or comparison with theory)
  • Documented: all elements (classes and their members, functions, namespaces, etc.) are documented
  • Constified (All that can be const is const)
  • Code is clean (no unwanted comments, )
  • Style and code conventions are respected at the bottom of https://github.com/Hi-PACE/hipace
  • Proper label and GitHub project, if applicable

@SeverinDiederichs SeverinDiederichs added component: fields About 3D fields and slices, field solvers etc. cleaning Code cleaning, avoid duplication, better naming, better style etc. labels Apr 14, 2021
@MaxThevenet MaxThevenet merged commit 5958c8c into development Apr 17, 2021
@MaxThevenet MaxThevenet deleted the fix_psi_sign branch April 17, 2021 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleaning Code cleaning, avoid duplication, better naming, better style etc. component: fields About 3D fields and slices, field solvers etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants