Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cuFFTUtils: Add Missing Include #461

Merged
merged 1 commit into from
Apr 23, 2021
Merged

cuFFTUtils: Add Missing Include #461

merged 1 commit into from
Apr 23, 2021

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented Apr 20, 2021 •
edited
Loading

std::string from <string> is used in this file.

Fixes a user bug report (compilation error).

  • Small enough (< few 100s of lines), otherwise it should probably be split into smaller PRs
  • Tested (describe the tests in the PR description)
  • Runs on GPU (basic: the code compiles and run well with the new module)
  • Contains an automated test (checksum and/or comparison with theory)
  • Documented: all elements (classes and their members, functions, namespaces, etc.) are documented
  • Constified (All that can be const is const)
  • Code is clean (no unwanted comments, )
  • Style and code conventions are respected at the bottom of https://github.com/Hi-PACE/hipace
  • Proper label and GitHub project, if applicable

@ax3l
cuFFTUtils: Add Missing Include
7077044 
`std::string` from `<string>` is used in this file.
@ax3l ax3l added the bug Something isn't working label Apr 20, 2021
@ax3l ax3l requested a review from MaxThevenet April 20, 2021 17:05
MaxThevenet
MaxThevenet approved these changes Apr 23, 2021
View reviewed changes
Copy link
Member

@MaxThevenet MaxThevenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@MaxThevenet MaxThevenet merged commit d0f5a2f into development Apr 23, 2021
@MaxThevenet MaxThevenet deleted the fix-cuFFTincludeString branch April 23, 2021 06:39
@MaxThevenet
Copy link
Member

MaxThevenet commented Apr 23, 2021 •
edited
Loading

Thanks! This was merged :). Or did I miss something?

@ax3l
Copy link
Member Author

ax3l commented Apr 23, 2021 •
edited
Loading

Oh all good, I am just pedantic from the GitHub times where reviewers and assigned maintainer were not independent options 😅
Sorry, didn't know that triggers a post-merge notification for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxThevenet MaxThevenet MaxThevenet approved these changes

Assignees

@MaxThevenet MaxThevenet

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ax3l @MaxThevenet