Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mesh refinement: fix boxarray #529

Merged

Conversation

SeverinDiederichs
Copy link
Member

@SeverinDiederichs SeverinDiederichs commented Jun 14, 2021

This PR fixes a few things:

the BoxArray on level 1 is now correct. It was already correct transversely, but not longitudinally. Here, we construct it from the correct transverse part and the longitudinal part from level 0. DefineSliceGDB is now called per level and adapted correctly.

This PR does not fix that the plasma etc, which use some of the variables touched here are initialized per level. They are still just initialized on level 0, this will be fixed in an upcoming PR.

Majority of this PR was authored by @MaxThevenet.

  • Small enough (< few 100s of lines), otherwise it should probably be split into smaller PRs
  • Tested (describe the tests in the PR description)
  • Runs on GPU (basic: the code compiles and run well with the new module)
  • Contains an automated test (checksum and/or comparison with theory)
  • Documented: all elements (classes and their members, functions, namespaces, etc.) are documented
  • Constified (All that can be const is const)
  • Code is clean (no unwanted comments, )
  • Style and code conventions are respected at the bottom of https://github.com/Hi-PACE/hipace
  • Proper label and GitHub project, if applicable

src/Hipace.cpp Show resolved Hide resolved
Co-authored-by: MaxThevenet <maxence.thevenet@desy.de>
@SeverinDiederichs SeverinDiederichs merged commit 06b0b28 into Hi-PACE:development Jun 14, 2021
@SeverinDiederichs SeverinDiederichs deleted the mr_fix_box_array_clean branch June 14, 2021 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants