Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix transverse size of IO for level 1 #569

Merged
merged 3 commits into from
Jul 28, 2021

Conversation

SeverinDiederichs
Copy link
Member

@SeverinDiederichs SeverinDiederichs commented Jul 21, 2021

Previously, the size of level 1 IO was the full domain multiplied with the refinement ratio. Now it is at least transversely the correct size.
For the longitudinal resizing, the original box offset etc needs to be known. This is currently not the case.

This will be done in another PR.

  • Small enough (< few 100s of lines), otherwise it should probably be split into smaller PRs
  • Tested (describe the tests in the PR description)
  • Runs on GPU (basic: the code compiles and run well with the new module)
  • Contains an automated test (checksum and/or comparison with theory)
  • Documented: all elements (classes and their members, functions, namespaces, etc.) are documented
  • Constified (All that can be const is const)
  • Code is clean (no unwanted comments, )
  • Style and code conventions are respected at the bottom of https://github.com/Hi-PACE/hipace
  • Proper label and GitHub project, if applicable

@SeverinDiederichs SeverinDiederichs added the component: diagnostics About any types of diagnostics label Jul 21, 2021
@SeverinDiederichs SeverinDiederichs added the mesh refinement anything related to mesh refinement label Jul 22, 2021
@SeverinDiederichs SeverinDiederichs changed the title [WIP] fix size of IO for level 1 fix transverse size of IO for level 1 Jul 28, 2021
Copy link
Member Author

@SeverinDiederichs SeverinDiederichs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove deprecated comments

src/diagnostics/OpenPMDWriter.cpp Outdated Show resolved Hide resolved
src/diagnostics/OpenPMDWriter.cpp Outdated Show resolved Hide resolved
Copy link
Member

@MaxThevenet MaxThevenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for this PR!

@MaxThevenet MaxThevenet merged commit 4409666 into Hi-PACE:development Jul 28, 2021
@SeverinDiederichs SeverinDiederichs deleted the mr_fix_MR_IO branch August 1, 2021 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: diagnostics About any types of diagnostics mesh refinement anything related to mesh refinement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants