Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenMP handling #575

Merged
merged 4 commits into from
Jul 28, 2021
Merged

OpenMP handling #575

merged 4 commits into from
Jul 28, 2021

Conversation

MaxThevenet
Copy link
Member

Doc to use OpenMP efficiently on Juwels, and make openmp default

  • Small enough (< few 100s of lines), otherwise it should probably be split into smaller PRs
  • Tested (describe the tests in the PR description)
  • Runs on GPU (basic: the code compiles and run well with the new module)
  • Contains an automated test (checksum and/or comparison with theory)
  • Documented: all elements (classes and their members, functions, namespaces, etc.) are documented
  • Constified (All that can be const is const)
  • Code is clean (no unwanted comments, )
  • Style and code conventions are respected at the bottom of https://github.com/Hi-PACE/hipace
  • Proper label and GitHub project, if applicable

@MaxThevenet MaxThevenet added documentation Improvements or additions to documentation performance optimization, benchmark, profiling, etc. labels Jul 28, 2021
@SeverinDiederichs
Copy link
Member

SeverinDiederichs commented Jul 28, 2021

Hm, could we add a statement that it is absolutely forbidden to run production runs on the JUWELS Booster on CPU?
Maybe we should have a general CPU section in the documentation

@MaxThevenet
Copy link
Member Author

Right, I just added a warning. The booster is the only place were this was really tested, unfortunately, so I don't want to make it more general before we test it somewhere else.

Copy link
Member

@SeverinDiederichs SeverinDiederichs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MaxThevenet MaxThevenet merged commit b24fa46 into Hi-PACE:development Jul 28, 2021
@MaxThevenet MaxThevenet deleted the omp branch July 28, 2021 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation performance optimization, benchmark, profiling, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants