use correct inputs in NotifyFinish #590
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed incomplete communication calls on JUWELS by the following error:
This was caused by incorrect inputs into
NotifyFinish
, which was called viaNotifyFinish(true);
, but should have beenNotifyFinish(0 ,true);
, because the finishing of the ghost particle send must be on box 0. (The box parameter was simply missing).This PR fixes the problem and removes the error.
const
isconst
)