Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use correct inputs in NotifyFinish #590

Merged
merged 1 commit into from
Sep 3, 2021

Conversation

SeverinDiederichs
Copy link
Member

@SeverinDiederichs SeverinDiederichs commented Sep 2, 2021

We noticed incomplete communication calls on JUWELS by the following error:

[1630593559.537108] [jwb0097:21399:0]          mpool.c:43   UCX  WARN  object 0x1a214d00 was not returned to mpool ucp_requests
[1630593559.537689] [jwb0097:21396:0]          mpool.c:43   UCX  WARN  object 0x19786d00 was not returned to mpool ucp_requests
[1630593559.539651] [jwb0097:21398:0]          mpool.c:43   UCX  WARN  object 0x19d59980 was not returned to mpool ucp_requests
[1630593559.538533] [jwb0097:21397:0]          mpool.c:43   UCX  WARN  object 0x194ddd00 was not returned to mpool ucp_requests

This was caused by incorrect inputs into NotifyFinish, which was called via NotifyFinish(true);, but should have been NotifyFinish(0 ,true);, because the finishing of the ghost particle send must be on box 0. (The box parameter was simply missing).

This PR fixes the problem and removes the error.

  • Small enough (< few 100s of lines), otherwise it should probably be split into smaller PRs
  • Tested (describe the tests in the PR description)
  • Runs on GPU (basic: the code compiles and run well with the new module)
  • Contains an automated test (checksum and/or comparison with theory)
  • Documented: all elements (classes and their members, functions, namespaces, etc.) are documented
  • Constified (All that can be const is const)
  • Code is clean (no unwanted comments, )
  • Style and code conventions are respected at the bottom of https://github.com/Hi-PACE/hipace
  • Proper label and GitHub project, if applicable

@SeverinDiederichs SeverinDiederichs added bug Something isn't working Parallelization Longitudinal and transverse MPI decomposition labels Sep 2, 2021
@MaxThevenet MaxThevenet merged commit 1659097 into Hi-PACE:development Sep 3, 2021
@SeverinDiederichs SeverinDiederichs deleted the fix_comm branch September 3, 2021 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Parallelization Longitudinal and transverse MPI decomposition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants