Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variable plasma density #605

Merged
merged 27 commits into from
Oct 13, 2021

Conversation

AlexanderSinn
Copy link
Member

This PR addresses #597

<plasma name>.density is now replaced with <plasma name>.density(x,y,z) which can take a function of x, y and z.
x and y coordinates are taken from the simulation box and z = time * c.
The density gets recalculated at the beginning of every timestep.

If specified as a command line parameter, quotation marks must be added:
"<plasma name>.density(x,y,z)" = "1.".

  • Small enough (< few 100s of lines), otherwise it should probably be split into smaller PRs
  • Tested (describe the tests in the PR description)
  • Runs on GPU (basic: the code compiles and run well with the new module)
  • Contains an automated test (checksum and/or comparison with theory)
  • Documented: all elements (classes and their members, functions, namespaces, etc.) are documented
  • Constified (All that can be const is const)
  • Code is clean (no unwanted comments, )
  • Style and code conventions are respected at the bottom of https://github.com/Hi-PACE/hipace
  • Proper label and GitHub project, if applicable

@AlexanderSinn AlexanderSinn added the component: plasma About the plasma species label Oct 6, 2021
Copy link
Member

@MaxThevenet MaxThevenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thanks for this PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: plasma About the plasma species
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants