Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use correct CUDA version on maxwell #616

Merged
merged 1 commit into from
Nov 4, 2021
Merged

Conversation

SeverinDiederichs
Copy link
Member

CUDA 11.1 introduced a bug, which leads to an empty result for FFTs > 1024x1024 grid points.
This bug is not prevalent in CUDA 11.3 (I think it got fixed in CUDA 11.2).

This PR updates the documentation on installing on maxwell, to save users from running into this nasty bug.

  • Small enough (< few 100s of lines), otherwise it should probably be split into smaller PRs
  • Tested (describe the tests in the PR description)
  • Runs on GPU (basic: the code compiles and run well with the new module)
  • Contains an automated test (checksum and/or comparison with theory)
  • Documented: all elements (classes and their members, functions, namespaces, etc.) are documented
  • Constified (All that can be const is const)
  • Code is clean (no unwanted comments, )
  • Style and code conventions are respected at the bottom of https://github.com/Hi-PACE/hipace
  • Proper label and GitHub project, if applicable

@SeverinDiederichs SeverinDiederichs added bug Something isn't working documentation Improvements or additions to documentation build CMake, compilation, etc. labels Nov 4, 2021
Copy link
Member

@MaxThevenet MaxThevenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@SeverinDiederichs SeverinDiederichs merged commit 4780b4c into development Nov 4, 2021
@SeverinDiederichs SeverinDiederichs deleted the fix_max_doc branch November 4, 2021 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working build CMake, compilation, etc. documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants