Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate hipace.do_adaptive_time_step #619

Merged

Conversation

SeverinDiederichs
Copy link
Member

@SeverinDiederichs SeverinDiederichs commented Nov 17, 2021

This small PR deprecates hipace.do_adaptive_time_step, so users get a proper error message when they try to use the deprecated form, instead of hipace.dt = adaptive.

  • Small enough (< few 100s of lines), otherwise it should probably be split into smaller PRs
  • Tested (describe the tests in the PR description)
  • Runs on GPU (basic: the code compiles and run well with the new module)
  • Contains an automated test (checksum and/or comparison with theory)
  • Documented: all elements (classes and their members, functions, namespaces, etc.) are documented
  • Constified (All that can be const is const)
  • Code is clean (no unwanted comments, )
  • Style and code conventions are respected at the bottom of https://github.com/Hi-PACE/hipace
  • Proper label and GitHub project, if applicable

Sorry, something went wrong.

@SeverinDiederichs SeverinDiederichs added the cleaning Code cleaning, avoid duplication, better naming, better style etc. label Nov 17, 2021
@MaxThevenet MaxThevenet merged commit f33972d into Hi-PACE:development Nov 17, 2021
@SeverinDiederichs SeverinDiederichs deleted the deprecate_adaptive_input branch November 17, 2021 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleaning Code cleaning, avoid duplication, better naming, better style etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants