-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix errors in I/O #818
Fix errors in I/O #818
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR! I had a suggestion of a few lines, I couldn't do it through GH, comments, so I opened a small PR to your branch instead.
Merge if statements
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR!
This PR resolves #815
As @AlexanderSinn pointed out, an
openPMD::series
is appended to theoutputSeries
vector at each time step. This vector was intended to be a vector over levels.In this PR, the outputSeries vector is initialized once per level and per time step, and the series is reset at the end of the time step. This removes the unwanted openPMD series, which then give errors since they were never used, but also the problem that the IO of prematurely exited simulation was unusable. Now, it is usable for the finished time steps. Note, that it will still give an error if half-written time steps are in the directory. Still, with this PR it is possible to copy iterations to other folders and analyze them before the full run is finished.
const
isconst
)