Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove spurious comments in laser handling #828

Merged
merged 1 commit into from
Nov 28, 2022
Merged

Remove spurious comments in laser handling #828

merged 1 commit into from
Nov 28, 2022

Conversation

MaxThevenet
Copy link
Member

No description provided.

@MaxThevenet MaxThevenet added cleaning Code cleaning, avoid duplication, better naming, better style etc. component: laser envelope About the laser envelope solver labels Nov 27, 2022
@MaxThevenet MaxThevenet marked this pull request as ready for review November 27, 2022 12:50
SeverinDiederichs
SeverinDiederichs approved these changes Nov 28, 2022
View reviewed changes
Copy link
Member

@SeverinDiederichs SeverinDiederichs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleaning. Could be revived later if needed

@MaxThevenet MaxThevenet merged commit adc83a3 into Hi-PACE:development Nov 28, 2022
@MaxThevenet MaxThevenet deleted the cleanlaser branch November 28, 2022 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeverinDiederichs SeverinDiederichs SeverinDiederichs approved these changes

Assignees
No one assigned
Labels
cleaning Code cleaning, avoid duplication, better naming, better style etc. component: laser envelope About the laser envelope solver
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MaxThevenet @SeverinDiederichs