Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add derivative shape factors #831

Merged

Conversation

AlexanderSinn
Copy link
Member

@AlexanderSinn AlexanderSinn commented Nov 29, 2022

Runtime in s of ExplicitDeposition() with 2 2 ppc of electrons and ions with 1024*1024*2048 cells:

order dev PR centered PR nodal PR analytic
0 3.007 1.881 1.778 N/A
1 5.161 2.838 2.360 1.778
2 7.645 4.632 3.678 2.491
3 11.130 6.900 5.534 3.691

image
image
image
image

Depos order = 2, dev:
image
image
PR centered (Numerically identical, new default):
image
image
PR nodal:
image
image
PR analytic:
image
image

  • Small enough (< few 100s of lines), otherwise it should probably be split into smaller PRs
  • Tested (describe the tests in the PR description)
  • Runs on GPU (basic: the code compiles and run well with the new module)
  • Contains an automated test (checksum and/or comparison with theory)
  • Documented: all elements (classes and their members, functions, namespaces, etc.) are documented
  • Constified (All that can be const is const)
  • Code is clean (no unwanted comments, )
  • Style and code conventions are respected at the bottom of https://github.com/Hi-PACE/hipace
  • Proper label and GitHub project, if applicable

@AlexanderSinn AlexanderSinn added component: plasma About the plasma species GPU Related to GPU acceleration performance optimization, benchmark, profiling, etc. labels Nov 29, 2022
Copy link
Member

@MaxThevenet MaxThevenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR! See minor comments in the text. A few additional points:

  1. Could you add a PR description and illustrate the effect of this PR? For instance, on GPU, could you show some xy or xz cut for nodal and centered depositions, and give the runtime difference?
  2. I think a little convergence test would be very nice here, increasing transverse resolution by factors of 22, 44 etc. and show e.g. the beam emittance after 100 fixed time steps, with each depositions.

I would be happy to discuss this, and I believe point 2 above could show very nice results!

@MaxThevenet
Copy link
Member

MaxThevenet commented Dec 2, 2022

Great, thanks! Although not urgent, a convergence test could demonstrate that this new scheme is both faster and more accurate, which would be a very nice result!

@MaxThevenet MaxThevenet merged commit a5ab0cc into Hi-PACE:development Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: plasma About the plasma species GPU Related to GPU acceleration performance optimization, benchmark, profiling, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants