Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent perfectly centered plasma particle #861

Conversation

AlexanderSinn
Copy link
Member

  • Small enough (< few 100s of lines), otherwise it should probably be split into smaller PRs
  • Tested (describe the tests in the PR description)
  • Runs on GPU (basic: the code compiles and run well with the new module)
  • Contains an automated test (checksum and/or comparison with theory)
  • Documented: all elements (classes and their members, functions, namespaces, etc.) are documented
  • Constified (All that can be const is const)
  • Code is clean (no unwanted comments, )
  • Style and code conventions are respected at the bottom of https://github.com/Hi-PACE/hipace
  • Proper label and GitHub project, if applicable

Copy link
Member

@MaxThevenet MaxThevenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks! This fixes an issue identified by @AlexanderSinn: in a perfectly symmetric setup the macro-particle exactly on axis (which can happen with an odd number of cells) is on a very unstable position (for a symmetrical beam on axis), and would be kicked transversally in a random direction seeded by machine-precision noise, introducing randomness in a supposedly fully symmetrical and deterministic setup.

src/particles/plasma/PlasmaParticleContainerInit.cpp Outdated Show resolved Hide resolved
@AlexanderSinn AlexanderSinn added the component: plasma About the plasma species label Feb 6, 2023
@MaxThevenet MaxThevenet merged commit 856b948 into Hi-PACE:development Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: plasma About the plasma species
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants