Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase tolerance on production runs #875

Merged
merged 2 commits into from
Feb 28, 2023

Conversation

MaxThevenet
Copy link
Member

@MaxThevenet MaxThevenet commented Feb 28, 2023

CI production runs fail randomly, could be because of platform-dependent RNG for fixed-weight Gaussian particle beam. This PR increases the tolerance (by a lot), so the test should just catch large discrepancies. We could instead use an external beam to avoid the RNG issue, or have a separate tolerance for most sensitive fields, or just skip them.

@MaxThevenet MaxThevenet added the CI Continuous integration, checksum and analysis tests, GitHub Actions, etc. label Feb 28, 2023
@MaxThevenet MaxThevenet merged commit 3808506 into Hi-PACE:development Feb 28, 2023
@MaxThevenet MaxThevenet deleted the prodtol branch February 28, 2023 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous integration, checksum and analysis tests, GitHub Actions, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants