Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mini] Remove unused variable in adaptive time step #889

Merged
merged 1 commit into from
Mar 10, 2023
Merged

[mini] Remove unused variable in adaptive time step #889

merged 1 commit into from
Mar 10, 2023

Conversation

MaxThevenet
Copy link
Member

comm_z_tag is useless with MPI_Bcast. This came up as a compile warning with NVCC.

@MaxThevenet MaxThevenet added cleaning Code cleaning, avoid duplication, better naming, better style etc. build CMake, compilation, etc. Parallelization Longitudinal and transverse MPI decomposition labels Mar 10, 2023
SeverinDiederichs
SeverinDiederichs approved these changes Mar 10, 2023
View reviewed changes
Copy link
Member

@SeverinDiederichs SeverinDiederichs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleaning

@MaxThevenet MaxThevenet merged commit aa2711f into Hi-PACE:development Mar 10, 2023
@MaxThevenet MaxThevenet deleted the clc branch March 10, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeverinDiederichs SeverinDiederichs SeverinDiederichs approved these changes

Assignees
No one assigned
Labels
build CMake, compilation, etc. cleaning Code cleaning, avoid duplication, better naming, better style etc. Parallelization Longitudinal and transverse MPI decomposition
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MaxThevenet @SeverinDiederichs