Better defaults for production (in particular adaptive time step) #893
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
predict
andphase
options of adaptive time step by default. They make a huge difference in the presence of density ramps, see below.The figure below shows the final emittance after a PWFA stage, as a function of
nt_per_betatron
(the number of time steps per betatron period with adaptive time step), with the original adaptive time step, with featurepredict
on, with featurephase
on, and with both. It clearly converges much faster with both. The right plot shows the effect of the tolerance of thephase
feature.adaptive_new.pdf