[mini] Set default subcycling to 10 #895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxThevenet
commented
Mar 21, 2023
Comment on lines
+56
to
+57
| assert((std_sim_x-std_theory)/std_theory < 2.e-3) | ||
| assert((std_sim_y-std_theory)/std_theory < 2.e-3) |
There was a problem hiding this comment.
I had to increase the tolerance, not sure why as the new solver should be more accurate. Should be OK, since this value is still low, and arbitrary.
|
It would be nice to have lines for 10 subcycles in the plot. |
|
Indeed, thanks, I added a few points with sub=10 in the plot above. |
AlexanderSinn
approved these changes
Mar 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This figures shows the final emittance (of a beam-driven wakefield stage) as a function of number of time steps, for various tolerance (of the adaptive time step) and sub-cycling levels. Each line is a scan over the number of time steps per betatron period. Subcycling dramatically improved convergence, and with 10 sub-cycles it should increase the runtime by < 10 %.
.