Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mini] Better print statement when checksum fails #905

Merged
merged 1 commit into from
Mar 31, 2023
Merged

[mini] Better print statement when checksum fails #905

merged 1 commit into from
Mar 31, 2023

Conversation

MaxThevenet
Copy link
Member

@MaxThevenet MaxThevenet commented Mar 31, 2023 •
edited
Loading

When a checksum test fails, print the test name before showing the new json file content.
Similar to ECP-WarpX/WarpX#3753.

@MaxThevenet MaxThevenet added the CI Continuous integration, checksum and analysis tests, GitHub Actions, etc. label Mar 31, 2023
SeverinDiederichs
SeverinDiederichs approved these changes Mar 31, 2023
View reviewed changes
Copy link
Member

@SeverinDiederichs SeverinDiederichs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always appreciated, thanks!

@MaxThevenet MaxThevenet merged commit e8bffc9 into Hi-PACE:development Mar 31, 2023
@MaxThevenet MaxThevenet deleted the checksum2 branch March 31, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeverinDiederichs SeverinDiederichs SeverinDiederichs approved these changes

Assignees
No one assigned
Labels
CI Continuous integration, checksum and analysis tests, GitHub Actions, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MaxThevenet @SeverinDiederichs