Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove /usr/local from brew cache #922

Merged

Conversation

AlexanderSinn
Copy link
Member

@AlexanderSinn AlexanderSinn commented Apr 17, 2023

It seems that it tried to cache a bunch of preinstalled software, e.g aws-cli, microsoft powershell and miniconda.
I replaced /usr/local with all specific subfolders it has minus the ones causing file already exists errors.

  • Small enough (< few 100s of lines), otherwise it should probably be split into smaller PRs
  • Tested (describe the tests in the PR description)
  • Runs on GPU (basic: the code compiles and run well with the new module)
  • Contains an automated test (checksum and/or comparison with theory)
  • Documented: all elements (classes and their members, functions, namespaces, etc.) are documented
  • Constified (All that can be const is const)
  • Code is clean (no unwanted comments, )
  • Style and code conventions are respected at the bottom of https://github.com/Hi-PACE/hipace
  • Proper label and GitHub project, if applicable

@AlexanderSinn AlexanderSinn added performance optimization, benchmark, profiling, etc. CI Continuous integration, checksum and analysis tests, GitHub Actions, etc. labels Apr 17, 2023
Copy link
Member

@MaxThevenet MaxThevenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@AlexanderSinn AlexanderSinn requested a review from ax3l April 19, 2023 15:46
@MaxThevenet MaxThevenet merged commit ab4335a into Hi-PACE:development Apr 20, 2023
This was referenced Apr 20, 2023
@MaxThevenet MaxThevenet mentioned this pull request Dec 6, 2023
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous integration, checksum and analysis tests, GitHub Actions, etc. performance optimization, benchmark, profiling, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants