Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mini] Fix b0 calculation in collisions #958

Merged
merged 2 commits into from
May 23, 2023

Conversation

SeverinDiederichs
Copy link
Member

@SeverinDiederichs SeverinDiederichs commented May 23, 2023

This is a small PR to disentangle PR #954. This PR fixes the bug that was also fixed in #954 and in WarpX at ECP-WarpX/WarpX#3928

This PR needs to reset the benchmarks, so that then #954 should not touch the benchmark.

  • Small enough (< few 100s of lines), otherwise it should probably be split into smaller PRs
  • Tested (describe the tests in the PR description)
  • Runs on GPU (basic: the code compiles and run well with the new module)
  • Contains an automated test (checksum and/or comparison with theory)
  • Documented: all elements (classes and their members, functions, namespaces, etc.) are documented
  • Constified (All that can be const is const)
  • Code is clean (no unwanted comments, )
  • Style and code conventions are respected at the bottom of https://github.com/Hi-PACE/hipace
  • Proper label and GitHub project, if applicable

@SeverinDiederichs SeverinDiederichs added bug Something isn't working component: plasma About the plasma species labels May 23, 2023
@SeverinDiederichs SeverinDiederichs changed the title Fix b0 calculation in collisions [mini] Fix b0 calculation in collisions May 23, 2023
@MaxThevenet MaxThevenet merged commit 34a2c8e into Hi-PACE:development May 23, 2023
@SeverinDiederichs SeverinDiederichs deleted the fix_b0_calc branch May 23, 2023 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working component: plasma About the plasma species
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants