-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable ionization in normalized units #962
Merged
MaxThevenet
merged 15 commits into
Hi-PACE:development
from
SeverinDiederichs:ioniz_norm_units
Jun 2, 2023
Merged
Enable ionization in normalized units #962
MaxThevenet
merged 15 commits into
Hi-PACE:development
from
SeverinDiederichs:ioniz_norm_units
Jun 2, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxThevenet
approved these changes
Jun 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for this PR! See comment below.
Co-authored-by: Maxence Thévenet <maxence.thevenet@desy.de>
MaxThevenet
approved these changes
Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR follows #954 and only should be reviewed after #954 is merged.
This PR enables ionization in normalized units. Since the electric field in physical units is needed, the background plasma density must be provided in SI units via
plasma.background_density_SI
.To do: proper assert that
plasma.background_density_SI
is provided in case of normalized units.The difference between SI and normalized units is negligible:
const
isconst
)