Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable ionization in normalized units #962

Merged
merged 15 commits into from
Jun 2, 2023

Conversation

SeverinDiederichs
Copy link
Member

@SeverinDiederichs SeverinDiederichs commented May 26, 2023

This PR follows #954 and only should be reviewed after #954 is merged.

This PR enables ionization in normalized units. Since the electric field in physical units is needed, the background plasma density must be provided in SI units via plasma.background_density_SI.

To do: proper assert that plasma.background_density_SI is provided in case of normalized units.

The difference between SI and normalized units is negligible:
Untitled

  • Small enough (< few 100s of lines), otherwise it should probably be split into smaller PRs
  • Tested (describe the tests in the PR description)
  • Runs on GPU (basic: the code compiles and run well with the new module)
  • Contains an automated test (checksum and/or comparison with theory)
  • Documented: all elements (classes and their members, functions, namespaces, etc.) are documented
  • Constified (All that can be const is const)
  • Code is clean (no unwanted comments, )
  • Style and code conventions are respected at the bottom of https://github.com/Hi-PACE/hipace
  • Proper label and GitHub project, if applicable

@SeverinDiederichs SeverinDiederichs added the component: plasma About the plasma species label May 26, 2023
Copy link
Member

@MaxThevenet MaxThevenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for this PR! See comment below.

src/particles/plasma/PlasmaParticleContainer.cpp Outdated Show resolved Hide resolved
Co-authored-by: Maxence Thévenet <maxence.thevenet@desy.de>
@MaxThevenet MaxThevenet merged commit 417a845 into Hi-PACE:development Jun 2, 2023
@SeverinDiederichs SeverinDiederichs deleted the ioniz_norm_units branch June 2, 2023 05:49
@SeverinDiederichs SeverinDiederichs mentioned this pull request Jun 6, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: plasma About the plasma species
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants