Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mini] assert for normalized units when total charge is specified #969

Merged

Conversation

SeverinDiederichs
Copy link
Member

The option beam.total_charge does not make sense in normalized units, hence we assert for it now.

  • Small enough (< few 100s of lines), otherwise it should probably be split into smaller PRs
  • Tested (describe the tests in the PR description)
  • Runs on GPU (basic: the code compiles and run well with the new module)
  • Contains an automated test (checksum and/or comparison with theory)
  • Documented: all elements (classes and their members, functions, namespaces, etc.) are documented
  • Constified (All that can be const is const)
  • Code is clean (no unwanted comments, )
  • Style and code conventions are respected at the bottom of https://github.com/Hi-PACE/hipace
  • Proper label and GitHub project, if applicable

@SeverinDiederichs SeverinDiederichs added component: beam About the beam species cleaning Code cleaning, avoid duplication, better naming, better style etc. unit system handling of both SI and normalized units options labels Jun 2, 2023
@MaxThevenet MaxThevenet changed the title [minii] assert for normalized units when total charge is specified [mini] assert for normalized units when total charge is specified Jun 3, 2023
@MaxThevenet MaxThevenet added the non-backward-compatible Changes the behavior of the code, old input file may give different results label Jun 3, 2023
Co-authored-by: Maxence Thévenet <maxence.thevenet@desy.de>
@MaxThevenet MaxThevenet merged commit 89c0b94 into Hi-PACE:development Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleaning Code cleaning, avoid duplication, better naming, better style etc. component: beam About the beam species non-backward-compatible Changes the behavior of the code, old input file may give different results unit system handling of both SI and normalized units options
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants