Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Bz component to beam pusher #973

Merged

Conversation

SeverinDiederichs
Copy link
Member

Previously, the Bz component was missing the beam particle pusher. Although the contribution is often negligible, it should not be neglected..

  • Small enough (< few 100s of lines), otherwise it should probably be split into smaller PRs
  • Tested (describe the tests in the PR description)
  • Runs on GPU (basic: the code compiles and run well with the new module)
  • Contains an automated test (checksum and/or comparison with theory)
  • Documented: all elements (classes and their members, functions, namespaces, etc.) are documented
  • Constified (All that can be const is const)
  • Code is clean (no unwanted comments, )
  • Style and code conventions are respected at the bottom of https://github.com/Hi-PACE/hipace
  • Proper label and GitHub project, if applicable

@SeverinDiederichs SeverinDiederichs added bug Something isn't working component: beam About the beam species non-backward-compatible Changes the behavior of the code, old input file may give different results labels Jun 8, 2023
Copy link
Member

@MaxThevenet MaxThevenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, good catch, thanks!

@MaxThevenet MaxThevenet merged commit 6c21b2b into Hi-PACE:development Jun 8, 2023
@SeverinDiederichs SeverinDiederichs deleted the add_Bz_to_beampusher branch June 9, 2023 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working component: beam About the beam species non-backward-compatible Changes the behavior of the code, old input file may give different results
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants