Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add beam-plasma collisions #983

Merged
merged 14 commits into from
Jul 6, 2023

Conversation

SeverinDiederichs
Copy link
Member

@SeverinDiederichs SeverinDiederichs commented Jun 15, 2023

This PR extends the plasma collision module to do beam-plasma collisions

The implementation was tested against the theory in the following paper: Y. Yhao et al. Physics of Plasmas 27, 113105 (2020).

Using the same setup, Fig. 3 recreated with HiPACE++ looks like this:
Figure 39

Using more beam particles and more ions:
Figure 2

  • Small enough (< few 100s of lines), otherwise it should probably be split into smaller PRs
  • Tested (describe the tests in the PR description)
  • Runs on GPU (basic: the code compiles and run well with the new module)
  • Contains an automated test (checksum and/or comparison with theory)
  • Documented: all elements (classes and their members, functions, namespaces, etc.) are documented
  • Constified (All that can be const is const)
  • Code is clean (no unwanted comments, )
  • Style and code conventions are respected at the bottom of https://github.com/Hi-PACE/hipace
  • Proper label and GitHub project, if applicable

@SeverinDiederichs SeverinDiederichs added component: plasma About the plasma species component: beam About the beam species non-backward-compatible Changes the behavior of the code, old input file may give different results labels Jun 15, 2023
@SeverinDiederichs SeverinDiederichs changed the title [WIP] Add beam-plasma collisions Add beam-plasma collisions Jun 19, 2023
Copy link
Member

@MaxThevenet MaxThevenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for this PR!

Copy link
Member Author

@SeverinDiederichs SeverinDiederichs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove incorrect merging

docs/source/run/parameters.rst Outdated Show resolved Hide resolved
docs/source/run/parameters.rst Outdated Show resolved Hide resolved
docs/source/run/parameters.rst Outdated Show resolved Hide resolved
docs/source/run/parameters.rst Outdated Show resolved Hide resolved
docs/source/run/parameters.rst Outdated Show resolved Hide resolved
@MaxThevenet MaxThevenet merged commit e58453c into Hi-PACE:development Jul 6, 2023
@SeverinDiederichs SeverinDiederichs deleted the beam_plasma_coll branch July 6, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: beam About the beam species component: plasma About the plasma species non-backward-compatible Changes the behavior of the code, old input file may give different results
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants