[RIS-1225] Move to Ruby 3.0.x #52
Conversation
| @@ -103,3 +103,6 @@ Security/YAMLLoad: | |||
|
|
|||
| Style/RegexpLiteral: | |||
| Enabled: false | |||
|
|
|||
| Naming/VariableNumber: | |||
There was a problem hiding this comment.
Disabling this rule as it appears to apply to keys returned from the bambora API.
| spec.add_development_dependency 'pry' | ||
| spec.add_development_dependency 'pry-byebug' | ||
| spec.add_development_dependency 'rake', '~> 13.0' | ||
| spec.add_development_dependency 'rspec', '~> 3.0' | ||
| spec.add_development_dependency 'rspec_junit_formatter', '~> 0.4.1' | ||
| spec.add_development_dependency 'rubocop', '~> 0.74.0' | ||
| spec.add_development_dependency 'rubocop', '~> 1.12.0' |
There was a problem hiding this comment.
Minimum version bumps required to successfully run under Ruby 3.0
| @@ -8,7 +8,7 @@ def to_h | |||
| parsed_response = super | |||
| return error_response if parsed_response.values.flatten.empty? # We didn't get a query string back. | |||
|
|
|||
| parsed_response.each_with_object({}) { |(key, val), obj| obj[key] = val.length == 1 ? val.first : val } | |||
| parsed_response.transform_values { |val| val.length == 1 ? val.first : val } | |||
There was a problem hiding this comment.
Linting changes from the Rubocop change moving us to 3.0 compatibility. These were all from their "auto-correct" package.
| @@ -2,6 +2,6 @@ | |||
|
|
|||
| module Bambora | |||
| class Client | |||
| VERSION = '0.6.0' | |||
| VERSION = '0.7.0' | |||
There was a problem hiding this comment.
Version bump. Last time I forgot to create a tag and release to ruby-gems but this time I have the power! ⚔️
| # top-most EditorConfig file | ||
| root = true | ||
|
|
||
| # Unix-style newlines with a newline ending every file | ||
| # Indent with 2 spaces | ||
| [*] | ||
| end_of_line = lf | ||
| insert_final_newline = true | ||
| indent_style = space | ||
| indent_size = 2 |
There was a problem hiding this comment.
Being a good citizen 🖖
CHANGELOG.md
Outdated
| ## 0.7.0 (2024-02-05) | ||
|
|
||
| - Updating minimum Ruby version to Ruby 3.0.5 | ||
| - Add test support for Ruby 3.1, 3.2, 3.3 | ||
| - Updated Rubocop to enforce 3.0.x conventions | ||
| - Linting fixes | ||
|
|
||
| ## Unreleased (2023-12-01) |
There was a problem hiding this comment.
Can we merge this with the Unreleased items below? Also, can we more explicitly call out breaking change here, of removing support for Ruby 2.7.7. This library I believe is used by groups that are not just us anymore.
There was a problem hiding this comment.
Updated the wording. Keep in mind downstream clients can leverage Gemfile to sort out any issues with our released changes.
Ruby
2.7.7is EOL. Bumping to3.0.x.Post-merge:
v0.7.0tagRIS-1225