Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle multiple IsPrimary tables in join building in CohortBuilder/Extraction based on IsExtractionIdentifier #1365

Closed
tznind opened this issue Aug 15, 2022 · 0 comments · Fixed by #1366
Labels
eDRIS Driectly relating to use cases in the national safehaven e.g. MySql, Lookups etc enhancement

Comments

@tznind
Copy link
Contributor

tznind commented Aug 15, 2022

Is your feature request related to a problem? Please describe.
Sometimes you want to join from one table to another e.g. CT_StudyTable to US_StudyTable within a narrow use case (e.g. a CohortBuilder query). But both are likely to be flagged as IsPrimaryExtractionTable since they can each be used in isolation within their own hierarchy (study=>series=>image).

Describe the solution you'd like
Query builder should attempt to pick a 'winner' when there are 2+ IsPrimaryExtractionTable. To start with this should be the table that has the IsExtractionIdentifier field.

tznind added a commit that referenced this issue Aug 15, 2022
@tznind tznind added the eDRIS Driectly relating to use cases in the national safehaven e.g. MySql, Lookups etc label Aug 15, 2022
@tznind tznind moved this from Done to Demoed in RDMP August 29th Release Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
eDRIS Driectly relating to use cases in the national safehaven e.g. MySql, Lookups etc enhancement
Projects
No open projects
1 participant