Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure what columns are selected from lookup [Zsolt] #692

Closed
RoyMudie opened this issue Nov 23, 2021 · 4 comments · Fixed by #1179
Closed

Configure what columns are selected from lookup [Zsolt] #692

RoyMudie opened this issue Nov 23, 2021 · 4 comments · Fixed by #1179

Comments

@RoyMudie
Copy link
Contributor

RoyMudie commented Nov 23, 2021

At the moment RDMP extracts all columns from lookup tables.
In particular hic_dataLoadRunID and hic_validFrom would not be extracted usually.
Please enable the user to select what columns are selected from a lookup.

https://jira.hic.dundee.ac.uk/browse/RDMPSUP-140

@RoyMudie RoyMudie changed the title Configure what columns are selected from lookup Configure what columns are selected from lookup [Zsolt] Nov 23, 2021
@tznind
Copy link
Contributor

tznind commented Nov 25, 2021

In particular hic_dataLoadRunID and hic_validFrom would not be extracted usually.

The ColumnDropper can be used to define system wide rules about not extracting given columns (i.e. dropping them from the dataset being extracted).

Please enable the user to select what columns are selected from a lookup.

A SupportingSQL object (shown in the picture) allows selecting any columns you want from an arbitrary table as a 'lookup table'. If this is crashing consistently with the screenshot message then we need to look into that. It looks very low level error.

@tznind
Copy link
Contributor

tznind commented Nov 25, 2021

A Lookup object itself is different and is used in the creation of code/description relationships.

Lookups are created as follows:
image

Is this about whether the lookups appear in the the word metadata report e.g. here we can see the full Lookup table is getting examined for the Word Metadata Report:

image

@tznind
Copy link
Contributor

tznind commented Nov 25, 2021

Ok so to confirm:

  • You can extract whatever you want from a SupportingSql

For Lookup objects we can make the following changes

  • Only write into metadata documents the code and description column(s) of the Lookup
  • Only extract the code and description column(s) of the Lookup if it is included in an ExtractionConfiguration as a bundled lookup

Bear in mind that a Lookup can have multiple of each pk and desc column. For example where you have a test code AB1 that maps to 2 different tests - 1 in Tayside and 1 in Fife (so the join is TestCode+Healthboard => DrugDesc).

image

@tznind tznind self-assigned this Nov 25, 2021
@tznind
Copy link
Contributor

tznind commented May 11, 2022

I've updated the inital description to remove references to SupportingSQL which is a red herring for this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants