Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/rdmp 185 table import check fail #1836

Merged
merged 5 commits into from
May 23, 2024

Conversation

JFriel
Copy link
Collaborator

@JFriel JFriel commented May 22, 2024

Proposed Change

Fixes the issue raised in #1834
When checking a catalogue, we don't specify the tableInfo database name when creating the connection to the database.
This change checks if the tableInfo had a known database, if true it will use the known database, otherwise will use the db servers default database

Type of change

What types of changes does your code introduce? Tick all that apply.

  • Bugfix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation-Only Update
  • Other (if none of the other choices apply)

Checklist

By opening this PR, I confirm that I have:

  • Ensured that the PR branch is in sync with the target branch (i.e. it is automatically merge-able)
  • Created or updated any tests if relevant
  • Have validated this change against the Test Plan
  • Requested a review by one of the repository maintainers
  • Have written new documentation or updated existing documentation to detail any new or updated functionality and how to use it
  • Have added an entry into the changelog

@JFriel JFriel requested a review from jas88 May 22, 2024 08:45
Simplify LINQ - Where(x).Any() -> Any(x)
@@ -893,8 +893,8 @@ public void Check(ICheckNotifier notifier)

try
{
var server = DataAccessPortal.ExpectDistinctServer(tables, accessContext, false);

var setInitialDatabase = tables.Where(t => t.Database != null).Any();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to write Where(x).Any() as Any(x) - one less step.

@jas88 jas88 merged commit f100b65 into release/8.1.7 May 23, 2024
5 checks passed
@jas88 jas88 deleted the bugfix/RDMP-185-table-import-check-fail branch May 23, 2024 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants