RDMP-218 Use Historical Cohort Version #1901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Rdmp.Core/CommandExecution/AtomicCommands/ExecuteCommandRevertToHistoricalCohortVersion.cs
Fixed
Show fixed
Hide fixed
JFriel
commented
Jul 25, 2024
| @@ -117,6 +117,16 @@ private void VersionChange(object sender, EventArgs e) | |||
|
|
|||
| private void CommitNewVersion(object sender, EventArgs e) | |||
| { | |||
| if (_cic.Version != null && _activator.YesNo("Are you sure you want to revert the cohort to this version?", "Revert Cohort to this Version")) | |||
There was a problem hiding this comment.
make the no do nothing
| if (_cic.Version != null) | ||
| { | ||
| if (_activator.YesNo("Are you sure you want to revert the cohort to this version?", "Revert Cohort to this Version")) | ||
| { |
Check warning
Code scanning / CodeQL
Missing Dispose call on local IDisposable Warning
rdteviotdale
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Change
Add ability to use cohort version as new root cohort.
Replaced cohort config with clone of historical version
Type of change
What types of changes does your code introduce? Tick all that apply.
Checklist
By opening this PR, I confirm that I have: