Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/spillchuck #2133

Merged
merged 4 commits into from
Feb 13, 2025
Merged

Feature/spillchuck #2133

merged 4 commits into from
Feb 13, 2025

Conversation

jas88
Copy link
Member

@jas88 jas88 commented Feb 13, 2025

Proposed Change

Fix the odd typo here and there.

Type of change

What types of changes does your code introduce? Tick all that apply.

  • Bugfix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation-Only Update
  • Other (if none of the other choices apply)

Checklist

By opening this PR, I confirm that I have:

  • Ensured that the PR branch is in sync with the target branch (i.e. it is automatically merge-able)
  • Created or updated any tests if relevant
  • Have validated this change against the Test Plan
  • Requested a review by one of the repository maintainers
  • Have written new documentation or updated existing documentation to detail any new or updated functionality and how to use it
  • Have added an entry into the changelog

@jas88 jas88 requested a review from JFriel February 13, 2025 00:58
github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 13, 2025
View reviewed changes
Rdmp.Core/QueryBuilding/Parameters/ParameterManager.cs
Comment on lines 461 to +463
foreach (var parameters in ParametersFoundSoFarInQueryGeneration.Values)
if (parameters.Contains(deleteable))
parameters.Remove(deleteable);
if (parameters.Contains(deletable))
parameters.Remove(deletable);

Check notice

Code scanning / CodeQL

Missed opportunity to use Where Note

This foreach loop
implicitly filters its target sequence
Loading
- consider filtering the sequence explicitly using '.Where(...)'.
@JFriel JFriel merged commit 58af45a into develop Feb 13, 2025
6 of 7 checks passed
@JFriel JFriel deleted the feature/spillchuck branch February 13, 2025 09:47
@jas88 jas88 mentioned this pull request Feb 13, 2025
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JFriel JFriel JFriel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jas88 @JFriel