Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Cohort updating experience #666

Merged
merged 7 commits into from
Nov 18, 2021
Merged

Improve Cohort updating experience #666

merged 7 commits into from
Nov 18, 2021

Conversation

tznind
Copy link
Contributor

@tznind tznind commented Nov 18, 2021

Prior to this PR when updating a cohort there was a setting Deprecate Old Cohort On Success which defaulted to true. However just because a cohort was deprecated on an ExtractionConfiguration you could still extract it.

This PR contains 2 features:

  • IsDeprecated cohorts now come up as a failure during checks.
  • A new setting is added 'Migrate Usages' which updates unreleased ExtractionConfiguration to use the newest cohort

'Migrate Usages' is disabled by default to preserve backwards compatibility and because the Deprecated status check removes the risk of releasing the wrong cohort.

Fixes #650

IsDeprecated Fix:

image

Migrate Usages:
image

@tznind tznind requested a review from jas88 November 18, 2021 12:36
@tznind tznind changed the title Attempting to extract a config with a deprecated cohort now fails checks Improve Cohort updating experience Nov 18, 2021
@tznind tznind marked this pull request as ready for review November 18, 2021 13:26
@jas88 jas88 merged commit 7693bd9 into develop Nov 18, 2021
@jas88 jas88 deleted the dep-cohorts branch November 18, 2021 15:51
@RoyMudie
Copy link
Contributor

While MigrateUsages property in the pipeline is functional additional work required with DLS team to make sure all users needs are met.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto-Update ExtractionConfiguration cohort when creating a new ExracatableCohort version [Magalie]
3 participants