Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gave IsProperTransform CatalogueItems a custom icon #823

Merged
merged 1 commit into from
Dec 15, 2021

Conversation

tznind
Copy link
Contributor

@tznind tznind commented Dec 10, 2021

Fixes #818

image

I gave them a blue glow as software keywords are usually syntax highlighted in blue. Also green already means ProjectSpecific or yes extractable (basically stuff to do with extraction). Blue is softly associated with cohort building in RDMP but not so much that this becomes jaring I think.

@tznind tznind requested a review from RoyMudie December 10, 2021 13:55
@tznind
Copy link
Contributor Author

tznind commented Dec 10, 2021

@RoyMudie the icon is only on CatalogueItem not ExtractionInformation. Do you want that also updated?

@RoyMudie RoyMudie merged commit 8b6a9cd into develop Dec 15, 2021
@jas88 jas88 deleted the transform-icon branch January 11, 2023 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IsProperTransform should be shown with an icon
2 participants