Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magnet Chests #393

Closed
netherfoam opened this issue Oct 8, 2012 · 2 comments
Closed

Magnet Chests #393

netherfoam opened this issue Oct 8, 2012 · 2 comments

Comments

@netherfoam
Copy link

Hi,
I've written QuickShop (http://dev.bukkit.org/server-mods/quickshop), but some players are having issues with my display items and your magnets. Now the reason I come to you to ask instead of write my own fix is quite simple, and other people may have similar issues with display items etc.

When scanning for items to pick up, can you please check the time lived by the item, is greater than the tick delay before the item can be picked up? E.g. a spawned item (not itemstack) has
Item.getPickupDelay() and
Item.getTicksLived() properties.

If(Item.getPickupDelay() > Item.getTicksLived()) //Don't magnet the item into the chest

This is NOT just my plugin you're screwing, but anyone who uses a display item too. This is why the issue is with LWC. The time lived by items is also part of the bukkit API.

Thanks! :-)

@Hidendra
Copy link
Owner

Hidendra commented Oct 9, 2012

This will be added shortly, I don't think those methods existed when I first created magnets so it would be good to be able to finally fix that issue.

@Hidendra
Copy link
Owner

Hidendra commented Oct 9, 2012

Also in Jenkins #759

Hidendra added a commit that referenced this issue Feb 6, 2013
…longer than the pick up delay. It fixes instant item pickups (sometimes, when timed right) and also picking up items that plugins don't want picked up.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants