Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IO/FS/flush function to prelude #598

Closed
developedby opened this issue Jun 21, 2024 · 4 comments
Closed

Add IO/FS/flush function to prelude #598

developedby opened this issue Jun 21, 2024 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers HVM About the HVM prelude Bend's builtin types and functions

Comments

@developedby
Copy link
Member

HVM now exposes a file flushing primitive (HigherOrderCO/HVM#392), so we should create a function in the bend prelude to expose it to the users, like is done for the other file primitives.

@developedby developedby added enhancement New feature or request HVM About the HVM prelude Bend's builtin types and functions good first issue Good for newcomers labels Jun 21, 2024
@bhavik-goplani
Copy link
Contributor

@developedby Hey, I'd like to contribute to Bend. Do you think I can try this issue?

@developedby
Copy link
Member Author

Of course!
If you look at https://github.com/HigherOrderCO/Bend/pull/593/files, you can see more or less what you need to do, just update builtins.bend, builtins.md and changelog.md.
The function should be called IO/FS/flush, receive a file descriptor as argument and return nothing, like IO/FS/write returns nothing.

To test it you have to use the main branch from HVM since flush is not in a rleased version yet

@bhavik-goplani
Copy link
Contributor

Sounds good, thanks!

github-merge-queue bot pushed a commit that referenced this issue Jul 5, 2024
@developedby
Copy link
Member Author

Closed by #619

@developedby developedby added this to the Bend IO lib v0 milestone Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers HVM About the HVM prelude Bend's builtin types and functions
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants