-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't require Rust Nightly #352
Comments
reopening this, wouldn't it be better for the rust-toolchain.toml to have something like:
instead of completely deleting it? |
We don't need to override the user's rust toolchain, just setting the minimum rust version in the cargo.toml should be enough |
make sense |
HVM2 never needed rust nightly, so also drop `RUSTC_BOOSTRAP = true`. See HigherOrderCO/HVM#352
Reopening this. It's useful to have this file to enable reproducibles builds. |
i don't think that's necessary at all, you can just pass |
reclosing this. |
HVM2 never needed rust nightly, so also drop `RUSTC_BOOSTRAP = true`. See HigherOrderCO/HVM#352
Bend recently updated to not need rust nightly anymore.
Since hvm also doesn't need it to work and was only saying so that users only need one version of Rust to install both crates, we can now remove this requirement.
This means removing
rust-toolchain.toml
and removing mentions of rust nightly in the README.We could also add the minimum supported rust version to
Cargo.toml
, which I tested to be1.74
.The text was updated successfully, but these errors were encountered: