Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't require Rust Nightly #352

Closed
developedby opened this issue May 26, 2024 · 6 comments · Fixed by #353
Closed

Don't require Rust Nightly #352

developedby opened this issue May 26, 2024 · 6 comments · Fixed by #353

Comments

@developedby
Copy link
Member

Bend recently updated to not need rust nightly anymore.
Since hvm also doesn't need it to work and was only saying so that users only need one version of Rust to install both crates, we can now remove this requirement.

This means removing rust-toolchain.toml and removing mentions of rust nightly in the README.

We could also add the minimum supported rust version to Cargo.toml, which I tested to be 1.74.

@kings177
Copy link
Member

kings177 commented May 27, 2024

reopening this, wouldn't it be better for the rust-toolchain.toml to have something like:

[toolchain]
profile = "minimal"
channel = "1.74.0"
components = ["rustfmt", "clippy"]

instead of completely deleting it?

@developedby
Copy link
Member Author

reopening this, wouldn't it be better for the rust-toolchain.toml to have something like:

[toolchain]
profile = "minimal"
channel = "1.74.0"
components = ["rustfmt", "clippy"]

instead of completely deleting it?

We don't need to override the user's rust toolchain, just setting the minimum rust version in the cargo.toml should be enough

@kings177
Copy link
Member

make sense

wegank pushed a commit to NixOS/nixpkgs that referenced this issue May 29, 2024
HVM2 never needed rust nightly, so also drop `RUSTC_BOOSTRAP = true`.

See HigherOrderCO/HVM#352
@steinerkelvin
Copy link

steinerkelvin commented May 31, 2024

Reopening this. It's useful to have this file to enable reproducibles builds.

e.g. on https://github.com/fglab-tech/benda/blob/f9bf829a498c644bec6288bc652fc864d70b04d1/flake.nix#L20

@steinerkelvin steinerkelvin reopened this May 31, 2024
@kings177
Copy link
Member

i don't think that's necessary at all, you can just pass pkgs.rust-bin.stable.latest.default; to the flake.nix and that should work already, no?!

@kings177
Copy link
Member

kings177 commented Jun 5, 2024

reclosing this.

@kings177 kings177 closed this as completed Jun 5, 2024
florian-sanders-cc pushed a commit to florian-sanders-cc/nixpkgs that referenced this issue Jun 6, 2024
HVM2 never needed rust nightly, so also drop `RUSTC_BOOSTRAP = true`.

See HigherOrderCO/HVM#352
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants