-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implements #10 - validator.find() #37
Conversation
Just came back from holiday and will look at this PR this week. Before that can you rebase this on master, fix the tests and add tests to keep code coverage at 100%? The travis build and coveralls should be working now. |
path-to-regexp uses express style path, while OAS uses another syntax for path parameter, this implementation does not work with OAS path's like |
Finally taking a stab at resolving this PR. @backbone87 Thanks for pointing that out! I checked the V3 spec about paths and it seems like OpenAPI supports path params in format I have a problem making the OpenApiValidator.test.ts test case pass because TypeScript will not accept the second parameter. Types come from here. Talking about this line in the test: match(req, { ...baseRes }, () => {}); I've tried And the build is failing due to something unrelated:
|
@Hilzu Tests are green. |
This looks good. Thank you for your contribution and thanks for waiting this long to get the change merged. |
Addresses issue #10.
This is from an older branch I made when I needed this functionality in a project.
Let me know if there's something to adjust (namings, tests, something else) and I'll happily revisit this.