Small updates to temperature_from_filter_ratio #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The path to the model for hybrid abundances and photospheric abundances were switched.
Made atol scaled to temperature response to provide a more stringent test.
Made atol scaled to temperature response to provide a more stringent test.
Made atol scaled to temperature response to provide a more stringent test.
Made atol scaled to temperature response to provide a more stringent test.
Use atol and rtol values that should lead to passing all tests.
Use atol, rtol values that should lead to passing all tests.
Use atol, rtol values that should lead to passing all tests.
Use atol, rtol values that should lead to passing all tests.
needed to scale atol to max value of temperature response
need to scale atol to the max value of temperature response
for more information, see https://pre-commit.ci
…ak and xrt_deconvolve to that directory. Also moved associated tests and data
…tio. Also added fits keywords HGLN_OBS and HGLT_OBS to returned map metadata.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switched from print statements to calls to logger in temperature_from_filter_ratio. Also added keywords HGLN_OBS and HGLT_OBS to the metadata in the returned map objects, which prevents error messages emitted by map.plot