Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes so that effective area tests pass #310

Merged
merged 33 commits into from
Dec 19, 2024
Merged

fixes so that effective area tests pass #310

merged 33 commits into from
Dec 19, 2024

Conversation

jslavin
Copy link
Contributor

@jslavin jslavin commented Dec 19, 2024 •
edited
Loading

These fixes include:

  1. recalculation of the IDL effective area files using linear interpolation
  2. change to effective_area.py such that the effective area wavelength grid is the same as that used by IDL
  3. change to test_effective_area.py to include an absolute tolerance, atol, in addition to relative tolerance rtol.
    The actual differences in the calculated effective areas should be small.

jslavin and others added 30 commits June 5, 2023 16:15
@jslavin
Fix paths to spectral model files in temperature response
89796fa 
The path to the model for hybrid abundances and photospheric abundances were switched.
@jslavin
Fix atol in test_temperature_response_coronal.py
a4b0499 
Made atol scaled to temperature response to provide a more stringent test.
@jslavin
Fix atol in test_temperature_response_hybrid.py
c059468 
Made atol scaled to temperature response to provide a more stringent test.
@jslavin
Fix atol in test_temperature_response_photospheric.py
a5e7517 
Made atol scaled to temperature response to provide a more stringent test.
@jslavin
Fix atol in test_temperature_response.py
5e4c076 
Made atol scaled to temperature response to provide a more stringent test.
@jslavin
Fix atol, rtol values in test_temperature_response.py
fa641be 
Use atol and rtol values that should lead to passing all tests.
@jslavin
Fix atol, rtol values in test_temperature_response_coronal.py
412903b 
Use atol, rtol values that should lead to passing all tests.
@jslavin
Fix atol, rtol values in test_temperature_response_hybrid.py
184245a 
Use atol, rtol values that should lead to passing all tests.
@jslavin
Fix atol, rtol values in test_temperature_response_photospheric.py
d0f77fe 
Use atol, rtol values that should lead to passing all tests.
@jslavin
Another fix to test_temperature_response_hybrid.py
a4bcb14 
needed to scale atol to max value of temperature response
@jslavin
Another fix to test_temperature_response_coronal.py
9752563 
need to scale atol to the max value of temperature response
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
e7f82bd 
for more information, see https://pre-commit.ci
@jslavin
Merge branch 'main' of https://github.com/jslavin/xrtpy
6206ce5
@jslavin
Merge branch 'main' of https://github.com/jslavin/xrtpy
04124c5
@jslavin
Created new directory, image_correction, and moved xrt_remove_lightle…
8490dbb 
…ak and xrt_deconvolve to that directory. Also moved associated tests and data
@jslavin
small changes to image_correction/__init__.py
5b45c12
@jslavin
resolved conflicts
53d5985
@jslavin
Merge branch 'HinodeXRT:main' into main
8772fd6
@jslavin
Changed from print statements to logger in temperature_from_filter_ra…
9f8f9db 
…tio. Also added fits keywords HGLN_OBS and HGLT_OBS to returned map metadata.
@jslavin
Merge branch 'HinodeXRT:main' into main
22b2cda
@jslavin
Merge branch 'HinodeXRT:main' into main
cbfa352
@jslavin
Merge branch 'HinodeXRT:main' into main
1796ca2
@jslavin
Merge branch 'HinodeXRT:main' into main
5bcd1e2
@jslavin
Merge branch 'HinodeXRT:main' into main
cab492c
@jslavin
Merge branch 'HinodeXRT:main' into main
fc76550
@jslavin
Merge branch 'HinodeXRT:main' into main
88b8381
@jslavin
Merge branch 'HinodeXRT:main' into main
1aeabb1
@jslavin
Merge branch 'main' of https://github.com/jslavin/xrtpy
011528c
@jslavin
Merge branch 'main' of https://github.com/jslavin/xrtpy
8f16f66
@jslavin
Merge branch 'main' of https://github.com/jslavin/xrtpy
4e3ab15
@jslavin jslavin mentioned this pull request Dec 19, 2024
Closed
@jslavin jslavin merged commit e468feb into HinodeXRT:main Dec 19, 2024
8 checks passed
@joyvelasquez
Copy link
Contributor

Hi @nabobalis and @wtbarnes ,
@jslavin was able to debug the methods in numpy.allclose that we were using for testing. All Effective Area are passing. Thanks, Jon!

Closes #292: Regenerate IDL effective area test data

@joyvelasquez joyvelasquez added bug Something isn't working Code Improvement For general improvements to the codebase without adding new features. labels Dec 19, 2024
@joyvelasquez joyvelasquez added this to the 0.5.0 milestone Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working Code Improvement For general improvements to the codebase without adding new features.
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jslavin @joyvelasquez