-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Hybrid Temperature Response IDL Files with Updated Effective Area (Linear Interpolation) #314
base: main
Are you sure you want to change the base?
Conversation
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
I'm not entirely sure that we're using the same data, but I did try to compare some temperature responses that you sent me to some XRTpy generated responses and got large differences. I have no idea what the source of the differences is. |
@jslavin , When you're comparing, please ensure that the abundance types are being matched (I’m sure you’re aware, but just thought I’d mention)—for example, hybrid to hybrid or corona to corona. I also noticed the differences in the files. The key is that the response is being calculated using the updated effective area interpolation method we discussed last week. The reasoning for the three different pull requests is to have these updated temperature response text files separated for easier reading and processing. I’ll finish updating the coronal files today. Once these are updated, we can move forward with testing and see if we come accoress any issues. We might have to update the test like you did with the Effective area testing. |
Updating all hybrid temperature response IDL files in the repository to reflect the new effective area calculations using IDL's linear interpolation method. The updated files ensure consistency and accuracy for temperature response calculations based on the latest IDL effective area data.