Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Coronal Temperature Response IDL Files with Updated Effective Area (Linear Interpolation) #316

Open
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

joyvelasquez
Copy link
Contributor

Updating all coronal temperature response IDL files in the repository to reflect the new effective area calculations using IDL's linear interpolation method. The updated files ensure consistency and accuracy for temperature response calculations based on the latest IDL effective area data.

@joyvelasquez
Copy link
Contributor Author

pre-commit.ci autofix

@joyvelasquez joyvelasquez requested a review from jslavin December 30, 2024 20:45
@nabobalis
Copy link
Member

How are the IDL files created?

@joyvelasquez
Copy link
Contributor Author

@nabobalis , @jslavin
The IDL text files used for testing were created in SSW-IDL using make_xrt_temp_resp to generate the temperature response values. However, the reason for updating all the temperature responses is that these values are calculated based on the effective area. Both the IDL effective area code and the XRTpy code have been updated to use linear interpolation. As a result, the temperature response IDL text testing files need to be updated as well while referecning the new Effective Area linear interpolation. (I hope this was clear)

I’m going to start a new PR shortly to ensure that the current temperature response calculations/values fail or are flagged as invalid when calculated with the updated effective area linear interpolation. This will highlight the need for updating the temperature response files.

@nabobalis
Copy link
Member

nabobalis commented Dec 30, 2024

Is that IDL code stored in the repo, so that all of these files can be updated in the future by running one pro file?

@joyvelasquez
Copy link
Contributor Author

We currently have two IDL scripts in the repository that generate these testing files when run in IDL. However, there have been some updates—thank you for noting that! I’ll make sure to update the IDL files accordingly. I’ll also create an issue to ensure I don’t forget.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants