Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TypeScript usage example #187

Merged
merged 6 commits into from
Nov 20, 2024
Merged

Conversation

ScreamZ
Copy link
Contributor

@ScreamZ ScreamZ commented Nov 18, 2024

Added my version of the TypeScript starter template as a first step for #186

Copy link
Owner

@HipsterBrown HipsterBrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating this guide @ScreamZ 👏

I've added a few comments and suggestions to make sure what's being documented is accurate and as seamless as possible for getting started.

I think this will be a very good starting point for many TypeScript devs. 😄

docs/src/content/docs/guide/usage-with-typescript.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/guide/usage-with-typescript.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/guide/usage-with-typescript.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/guide/usage-with-typescript.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/guide/usage-with-typescript.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/guide/usage-with-typescript.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/guide/usage-with-typescript.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/guide/usage-with-typescript.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/guide/usage-with-typescript.mdx Outdated Show resolved Hide resolved
ScreamZ and others added 2 commits November 18, 2024 21:00
Co-authored-by: Nick Hehr <headhipster@hipsterbrown.com>
@ScreamZ
Copy link
Contributor Author

ScreamZ commented Nov 20, 2024

Made some changes according to your suggestions, I let you review them,

Copy link
Owner

@HipsterBrown HipsterBrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more suggested updates and questions, otherwise it's looking ready to go!

docs/src/content/docs/guide/usage-with-typescript.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/guide/usage-with-typescript.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/guide/usage-with-typescript.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/guide/usage-with-typescript.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/guide/usage-with-typescript.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/guide/usage-with-typescript.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/guide/usage-with-typescript.mdx Outdated Show resolved Hide resolved
ScreamZ and others added 2 commits November 20, 2024 16:56
Co-authored-by: Nick Hehr <headhipster@hipsterbrown.com>
@ScreamZ
Copy link
Contributor Author

ScreamZ commented Nov 20, 2024

Looks ready for final review

Copy link
Owner

@HipsterBrown HipsterBrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for contributing this guide!

@HipsterBrown HipsterBrown merged commit e8475ac into HipsterBrown:main Nov 20, 2024
2 checks passed
Copy link
Contributor

🚀 PR was released in v0.33.2 🚀

@github-actions github-actions bot added the released This issue/pull request has been released. label Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants