Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added logs subcommand #6

Merged
merged 4 commits into from
Jul 2, 2020
Merged

Added logs subcommand #6

merged 4 commits into from
Jul 2, 2020

Conversation

Hirevo
Copy link
Owner

@Hirevo Hirevo commented Jun 26, 2020

This PR adds support for the new persist logs subcommand.

This command allows to display logs from one or more processes simultaneously, with options to:

  • include any number of missed logs messages
  • enabling/disabling the live streaming of new log messages as they get emitted

Here is the output of persist logs --help, for details:

persist-logs 0.1.0
Commands to manage process logs

USAGE:
    persist logs [FLAGS] [OPTIONS] [process-name]...

FLAGS:
    -h, --help         Prints help information
        --no-stream    Disable log streaming
    -V, --version      Prints version information

OPTIONS:
    -n, --lines <lines>    The number of previous log lines to initially output [default: 10]

ARGS:
    <process-name>...    The names of the processes to get logs for

This PR also bumps all dependencies to their latest compatible version (with cargo update).

Refactored implementation of process handles
Bumped dependencies
@Hirevo Hirevo added C-enhancement Category: Enhancement M-daemon Module: Daemon M-cli Module: CLI P-high Priority: High labels Jun 26, 2020
@Hirevo Hirevo self-assigned this Jun 26, 2020
@Hirevo Hirevo mentioned this pull request Jun 28, 2020
Fixed log file descriptor leak in `ProcessHandle`
@Hirevo
Copy link
Owner Author

Hirevo commented Jul 2, 2020

I've been testing this subcommand for a few days now and I didn't find anything wrong or particularly missing.
I think we can merge this now. 🎉

@Hirevo Hirevo merged commit 4afc175 into master Jul 2, 2020
@Hirevo Hirevo deleted the feature/logs-subcommand branch July 2, 2020 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: Enhancement M-cli Module: CLI M-daemon Module: Daemon P-high Priority: High
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant